Re: [patch] GUC source file and line number - Mailing list pgsql-hackers

From Magnus Hagander
Subject Re: [patch] GUC source file and line number
Date
Msg-id 48B71FFD.3050407@hagander.net
Whole thread Raw
In response to Re: [patch] GUC source file and line number  (Greg Smith <gsmith@gregsmith.com>)
List pgsql-hackers
Greg Smith wrote:
> This looks quite handy.  Needs to have an update to the view-pg-settings
> section of the docs before it gets applied though.
> 
> I'd also like to get the default boot_val for each parameter exposed,
> similarly to how the min and max are available.  That should be easy to
> do using your changes as a guide for what to touch.  I'll try to fit
> that in this weekend so it makes the commitfest deadline.  I'll update
> the docs for all the changes (the ones in there already and the one I
> add) while I'm at it and submit a combined patch.

Doing that is going to be a whole lot easier and less invasive, so I'd
suggest doing it as a separate patch. While there may be a small
conflict, it's going to be easy to resolve, and I think keeping them
apart makes it a lot easier to review - at least to review the simple patch.

//Magnus



pgsql-hackers by date:

Previous
From: Greg Smith
Date:
Subject: Re: [patch] GUC source file and line number
Next
From: ITAGAKI Takahiro
Date:
Subject: Re: Auto-explain patch