Re: temporary statistics option at initdb time - Mailing list pgsql-hackers

From Magnus Hagander
Subject Re: temporary statistics option at initdb time
Date
Msg-id 48B2D0CF.9010209@hagander.net
Whole thread Raw
In response to Re: temporary statistics option at initdb time  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tom Lane wrote:
> Magnus Hagander <magnus@hagander.net> writes:
>> Tom Lane wrote:
>>> I think this is introducing complication and race conditions to solve a
>>> problem that no one will really care about.  Just let people change the
>>> filename at SIGHUP and document that doing that on-the-fly may cause
>>> stats queries to fail for a short interval.
> 
>> Ok, I'll do it that way.
> 
> BTW, it might be worth tweaking the stats collector to dump stats
> immediately after responding to SIGHUP, just to narrow this window
> as much as possible.

Pah, that is too obvious :-)
Yeah, should've thought of that, will make that happen.


> [ squint... ]  Actually, it looks like the stats collector SIG_IGNores
> SIGHUP?  That can't be right (any more) can it?

It did, until after my patch that was applied a couple of minutes ago.
After the patch, it cares about SIGHUP.

//Magnus


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: temporary statistics option at initdb time
Next
From: Tom Lane
Date:
Subject: Re: temporary statistics option at initdb time