Re: [PATCHES] odd output in restore mode - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: [PATCHES] odd output in restore mode
Date
Msg-id 488DEE79.4010004@dunslane.net
Whole thread Raw
In response to Re: [PATCHES] odd output in restore mode  (Greg Smith <gsmith@gregsmith.com>)
Responses Re: [PATCHES] odd output in restore mode  ("Heikki Linnakangas" <heikki@enterprisedb.com>)
List pgsql-hackers

Greg Smith wrote:
> On Wed, 23 Jul 2008, Kevin Grittner wrote:
>
>> In our scripts we handle this by copying to a temp directory on the
>> same mount point as the archive directory and doing a mv to the
>> archive location when the copy is successfully completed. I think
>> that this even works on Windows. Could that just be documented as a
>> strong recommendation for the archive script?
>
> This is exactly what I always do. I think the way cp is shown in the
> examples promotes what's really a bad practice for lots of reasons,
> this particular problem being just one of them.
>
> I've been working on an improved archive_command shell script that I
> expect to submit for comments and potential inclusion in the
> documentation as a better base for other people to build on. This is
> one of the options for how it can operate. It would be painful but not
> impossible to convert a subset of that script to run under Windows as
> well, at least enough to cover this particular issue.
>
>

A Perl script using the (standard) File::Copy module along with the
builtin function rename() should be moderately portable. It would to be
nice not to have to maintain two scripts.

cheers

andrew

pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: Do we really want to migrate plproxy and citext into PG core distribution?
Next
From: "Marko Kreen"
Date:
Subject: dblink security