PATCH: Save settings regardless of Find&Replace dialog's close method - Mailing list pgadmin-hackers

From J.F. Oster
Subject PATCH: Save settings regardless of Find&Replace dialog's close method
Date
Msg-id 488548156.20140320193320@mail.ru
Whole thread Raw
Responses Re: PATCH: Save settings regardless of Find&Replace dialog's close method  (Ashesh Vashi <ashesh.vashi@enterprisedb.com>)
Re: PATCH: Save settings regardless of Find&Replace dialog's close method  (Ashesh Vashi <ashesh.vashi@enterprisedb.com>)
List pgadmin-hackers
Hello,

Make "Find & Replace" dialog in SQL Box remember search settings when
it is closed (in any way; in fact it's being hidden).

Existing instances of dialog, once invoked again, will keep their own
settings.
New instance of dialog will gain settings of the last dialog which has
been closed before it's invocation.



>>> By the way, I was puzzled why search dialog's settings are saved
>>> sometimes and sometimes are not. Depending on dialog's close method:
>>> 1. Pressing ESC or "Close" form button calls OnCancel() which does not
>>> save;
>>> 2. Pressing title [x] button or Alt-F4 (or similar OS hotkey) calls
>>> OnClose() which does save.
>>>
>>> Shouldn't the behaviour be the same regardless of dialog's close
>>> method? Or at least the difference should be noted in documentation.

DP>> Yes, it should. Patches welcome :-)

JFO> Ok, after the current patch is applied I'll send in another one to
JFO> make it save settings in both cases.


--
Best regards,
 J.F.

Attachment

pgadmin-hackers by date:

Previous
From: Ashesh Vashi
Date:
Subject: Re: PATCH: Enable backwards search in SQL Box
Next
From: Ashesh Vashi
Date:
Subject: Re: crypto library is not installed