Re: Review: UNNEST (and other functions) WITH ORDINALITY - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Review: UNNEST (and other functions) WITH ORDINALITY
Date
Msg-id 4869.1375037030@sss.pgh.pa.us
Whole thread Raw
In response to Re: Review: UNNEST (and other functions) WITH ORDINALITY  (Greg Stark <stark@mit.edu>)
Responses Re: Review: UNNEST (and other functions) WITH ORDINALITY
List pgsql-hackers
Greg Stark <stark@mit.edu> writes:
> Instead of collapsing WITH TIME and WITH ORDINALITY into a single
> token why don't we just modify the WITH token to WITH_FOLLOWED_BY_TIME
> and WITH_FOLLOWED_BY_ORDINALITY but still keep the following token.
> Then we can just include those two tokens everywhere we include WITH.
> Basically we would be giving the parser a free extra token of
> lookahead whenever it gets WITH.

> I think that's isomorphic to what Tom suggested but requires less
> surgery on the parser and automatically covers any other cases we
> don't need to track down.

I suspect it's likely to come out about the same either way once you
account for all the uses of WITH.  Might be worth trying both to see
which seems less ugly.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Greg Stark
Date:
Subject: Re: Review: UNNEST (and other functions) WITH ORDINALITY
Next
From: Andres Freund
Date:
Subject: Re: replication_reserved_connections