Re: Patch to change psql default banner v6 - Mailing list pgsql-patches

From Bryce Nesbitt
Subject Re: Patch to change psql default banner v6
Date
Msg-id 4832ECD7.7010605@obviously.com
Whole thread Raw
In response to Re: Patch to change psql default banner v6  (Guillaume Lelarge <guillaume@lelarge.info>)
Responses Re: Patch to change psql default banner v6
List pgsql-patches
Guillaume Lelarge wrote:
> Here is a patch that tries to implement this. Meta-commands should
> work from 7.4 to 8.4-devel releases. It was not hard to do, and I
> don't think it really is a burden to maintain.
>
> One part left to fix is \du and \dg commands. I would be glad to
> continue to work on this but I would prefer to have comments before.
Good work!  I submitted a similar patch also.

For your patch I have one critique: the version sensitive code is
scattered all through describe.c.  Are there opportunities to apply some
tests at a higher level (reducing the number of tests), or gather the
tests into an easily maintainable chunk?

The cleaner it is, the more likely future patchers will continue to
maintain compatibility.

                                  -Bryce Nesbitt


pgsql-patches by date:

Previous
From: Euler Taveira de Oliveira
Date:
Subject: Re: Simplify formatting.c
Next
From: "Merlin Moncure"
Date:
Subject: Re: libpq object hooks (libpq events)