Re: 'Waiting on lock' - Mailing list pgsql-hackers

From Tom Lane
Subject Re: 'Waiting on lock'
Date
Msg-id 4821.1180542442@sss.pgh.pa.us
Whole thread Raw
In response to Re: 'Waiting on lock'  (Stephen Frost <sfrost@snowman.net>)
Responses Re: 'Waiting on lock'
Re: 'Waiting on lock'
List pgsql-hackers
Stephen Frost <sfrost@snowman.net> writes:
> * Tom Lane (tgl@sss.pgh.pa.us) wrote:
>> It'd be relatively painless to make that happen as part of the
>> deadlock-check timeout function, but that's typically only a one-second
>> delay not a "few seconds".  I think it'd likely be overly chatty.

> Yeah, I wouldn't want one per second.  Do we already track how long
> we've been waiting?

No, because we're *asleep*.  You'd have to add an additional
timeout-interrupt reason.  Plus there's a ton of interesting questions
about what's safe to do from an interrupt service routine.

In fact, I am scandalized to see that someone has inserted a boatload
of elog calls into CheckDeadLock since 8.2 --- that seems entirely
unsafe.  [ checks revision history... ]

2007-03-03 13:46  momjian
* doc/src/sgml/config.sgml, src/backend/storage/lmgr/deadlock.c,src/backend/storage/lmgr/proc.c,
src/backend/utils/misc/guc.c,src/backend/utils/misc/postgresql.conf.sample,src/include/storage/lock.h,
src/include/storage/proc.h:Add GUClog_lock_waits to log long wait times.Simon Riggs
 

Bruce, Simon, kindly fix this or revert it.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Style of file error messages
Next
From: Alvaro Herrera
Date:
Subject: Re: 'Waiting on lock'