Re: pg_postmaster_reload_time() patch - Mailing list pgsql-patches

From Heikki Linnakangas
Subject Re: pg_postmaster_reload_time() patch
Date
Msg-id 481845C4.4040009@enterprisedb.com
Whole thread Raw
In response to Re: pg_postmaster_reload_time() patch  ("Gurjeet Singh" <singh.gurjeet@gmail.com>)
List pgsql-patches
Gurjeet Singh wrote:
> On Wed, Apr 30, 2008 at 9:53 AM, George Gensure <werkt0@gmail.com> wrote:
>
>> I've done a quick write up for reload time reporting from the
>> administration TODO.  I was a little paranoid with the locking, but
>> didn't want problems to occur with signals on the postmaster and the
>> read side.
>>
>>
> IMHO, the function should return NULL if the postmaster never reloaded; that
> is, it was started, but never signaled to reload.

I think it's useful to get the server startup time if the configuration
has never been reloaded. That's when the configuration was loaded, if no
reload has been triggered since. Perhaps the function should be named to
reflect that better. pg_configuration_load_time() ?

--
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com

pgsql-patches by date:

Previous
From: "Gurjeet Singh"
Date:
Subject: Re: pg_postmaster_reload_time() patch
Next
From: "Heikki Linnakangas"
Date:
Subject: Re: Patch to add a feature to pg_standby