Re: Add header support to text format and matching feature - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Add header support to text format and matching feature
Date
Msg-id 4816b2df-646f-dc19-e5cc-4bfbd04c0e43@enterprisedb.com
Whole thread Raw
In response to Re: Add header support to text format and matching feature  (Rémi Lapeyre <remi.lapeyre@lenstra.fr>)
Responses Re: Add header support to text format and matching feature
List pgsql-hackers
On 31.12.21 18:36, Rémi Lapeyre wrote:
> Here’s an updated version of the patch that takes into account the changes in d1029bb5a2. The actual code is the same
asv10 which was already marked as ready for committer.
 

I have committed the 0001 patch.  I will work on the 0002 patch next.

I notice in the 0002 patch that there is no test case for the error 
"wrong header for column \"%s\": got \"%s\"", which I think is really 
the core functionality of this patch.  So please add that.

I wonder whether the header matching should be a separate option from 
the HEADER option.  The option parsing in this patch is quite 
complicated and could be simpler if there were two separate options.  It 
appears this has been mentioned in the thread but not fully discussed.



pgsql-hackers by date:

Previous
From: Dipesh Pandit
Date:
Subject: Re: refactoring basebackup.c
Next
From: Kyotaro Horiguchi
Date:
Subject: Re: Is it correct to update db state in control file as "shutting down" during end-of-recovery checkpoint?