Re: Clean up some pg_dump tests - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Clean up some pg_dump tests
Date
Msg-id 4801515b-143e-4a4a-be5d-b65a5d461f69@eisentraut.org
Whole thread Raw
In response to Clean up some pg_dump tests  (Peter Eisentraut <peter@eisentraut.org>)
List pgsql-hackers
On 02.10.23 09:12, Peter Eisentraut wrote:
> 1) Remove useless entries from "unlike" lists.  Runs that are not
>     listed in "like" don't need to be excluded in "unlike".
> 
> 2) Ensure there is always a "like" list, even if it is empty.  This
>     makes the test more self-documenting.

> I also added code that checks 1 and 2 automatically and issues a message
> for violations.

I have recently discovered that the same code also exists separately in 
the test_pg_dump module test.  This should probably be kept consistent. 
So here is a patch that adds the same checks there.  In this case, we 
didn't need to fix any of the existing subtests.

I plan to commit this soon if there are no concerns.
Attachment

pgsql-hackers by date:

Previous
From: "David E. Wheeler"
Date:
Subject: Re: Patch: Add parse_type Function
Next
From: Jim Jones
Date:
Subject: Re: Patch: Add parse_type Function