Re: Code-Cleanup: char* -> const char* - Mailing list pgsql-patches

From Tom Lane
Subject Re: Code-Cleanup: char* -> const char*
Date
Msg-id 4800.1174234713@sss.pgh.pa.us
Whole thread Raw
In response to Re: Code-Cleanup: char* -> const char*  (Neil Conway <neilc@samurai.com>)
List pgsql-patches
Neil Conway <neilc@samurai.com> writes:
> I also don't see the value in modifying the regexp code, as that is just
> an import of Henry Spencer's regexp package.

The same objection applies to most of the proposed changes in /src/port/
since those are generally imports from BSD libc code.  I don't mind
cosmetic changes in files that are actually homegrown, but for imported
files it's probably best to avoid unnecessary delta from upstream.

            regards, tom lane

pgsql-patches by date:

Previous
From: "Mike Rylander"
Date:
Subject: Re: xml2 contrib patch supporting default XML namespaces
Next
From: ITAGAKI Takahiro
Date:
Subject: Re: ecpg threading vs win32