Re: [PATCH] Incremental sort - Mailing list pgsql-hackers

From David Steele
Subject Re: [PATCH] Incremental sort
Date
Msg-id 47ce55a6-dd08-d15b-e9cf-ecaebe25ee21@pgmasters.net
Whole thread Raw
In response to Re: [HACKERS] [PATCH] Incremental sort  (Heikki Linnakangas <hlinnaka@iki.fi>)
Responses Re: [PATCH] Incremental sort  (Alexander Korotkov <a.korotkov@postgrespro.ru>)
List pgsql-hackers
Hi Alexander,

On 3/20/17 10:19 AM, Heikki Linnakangas wrote:
> On 03/20/2017 11:33 AM, Alexander Korotkov wrote:
>> Please, find rebased patch in the attachment.
>
> I had a quick look at this.

<...>

> According to 'perf', 85% of the CPU time is spent in ExecCopySlot(). To
> alleviate that, it might be worthwhile to add a special case for when
> the group contains exactly one group, and not put the tuple to the
> tuplesort in that case. Or if we cannot ensure that the Incremental Sort
> is actually faster, the cost model should probably be smarter, to avoid
> picking an incremental sort when it's not a win.

This thread has been idle for over a week.  Please respond with a new 
patch by 2017-03-30 00:00 AoE (UTC-12) or this submission will be marked 
"Returned with Feedback".

-- 
-David
david@pgmasters.net



pgsql-hackers by date:

Previous
From: Simon Riggs
Date:
Subject: Re: Monitoring roles patch
Next
From: Simon Riggs
Date:
Subject: Re: logical decoding of two-phase transactions