Re: Fix for win32 stat() problems - Mailing list pgsql-patches

From Andrew Dunstan
Subject Re: Fix for win32 stat() problems
Date
Msg-id 47FD5401.5000509@dunslane.net
Whole thread Raw
In response to Re: Fix for win32 stat() problems  (Magnus Hagander <magnus@hagander.net>)
Responses Re: Fix for win32 stat() problems  (Alvaro Herrera <alvherre@commandprompt.com>)
List pgsql-patches

Magnus Hagander wrote:
> Tom Lane wrote:
>
>> Magnus Hagander <magnus@hagander.net> writes:
>>
>>> Trying to prepare a patch that does it the normal way, but so far
>>> I'm failing rather miserably. The *struct* stat is already
>>> redefined on win32, so whenever I try #undef or so it conflicts
>>> with that :-( Since there is no way to #undef only the parametrized
>>> version.
>>>
>> I don't follow ... there's no such redefinition in our code AFAICS.
>> Do you mean that the system header files declare it as a macro?
>>
>
> Yes.
>
>
>

How about #defining safe_stat to be pg_win32_safe_stat on Windows and
simply stat elsewhere? Then use safe_stat at the places you consider
critical.

cheers

andrew

pgsql-patches by date:

Previous
From: Magnus Hagander
Date:
Subject: Re: Fix for win32 stat() problems
Next
From: Gregory Stark
Date:
Subject: Re: EXPLAIN progress info