Re: pgsql: Make integer_datetimes the default on msvc as well, to have the - Mailing list pgsql-committers

From Andrew Dunstan
Subject Re: pgsql: Make integer_datetimes the default on msvc as well, to have the
Date
Msg-id 47FC0933.2040106@dunslane.net
Whole thread Raw
In response to pgsql: Make integer_datetimes the default on msvc as well, to have the  (mha@postgresql.org (Magnus Hagander))
Responses Re: pgsql: Make integer_datetimes the default on msvc as well, to have the
List pgsql-committers

Magnus Hagander wrote:
> Log Message:
> -----------
> Make integer_datetimes the default on msvc as well, to have the same
> default as other platforms.
>
> Modified Files:
> --------------
>     pgsql/src/tools/msvc:
>         config.pl (r1.9 -> r1.10)
>         (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/tools/msvc/config.pl?r1=1.9&r2=1.10)
>
>

I don't actually think this is the right way to do this. It's not the
same thing. The equivalent behaviour would be to have the flag turned on
even if there's nothing in the config file. What I think we need is to
add this line in Solution.pm::new():

   $options->{integer_datetimes} = 1 unless exists
$config->{integer_datetimes};

That way we turn the flag on if the config says nothing at all, but if
it says anything we respect what it says.

cheers

andrew

pgsql-committers by date:

Previous
From: gleu@pgfoundry.org (User Gleu)
Date:
Subject: pgsnap - pgsnap: Small typo.
Next
From: Andrew Dunstan
Date:
Subject: Re: pgsql: Make integer_datetimes the default on msvc as well, to have the