Re: Headers dependencies cleanup - Mailing list pgsql-patches

From Zdenek Kotala
Subject Re: Headers dependencies cleanup
Date
Msg-id 47FA00B3.4050600@sun.com
Whole thread Raw
In response to Re: Headers dependencies cleanup  (Bruce Momjian <bruce@momjian.us>)
List pgsql-patches
Bruce Momjian napsal(a):
> Zdenek Kotala wrote:
>> Tom Lane napsal(a):
>>> Zdenek Kotala <Zdenek.Kotala@Sun.COM> writes:
>>>>>> During my work I found some header files, which include useless headers
>>>>>> and on other way there are some headers which silently assume that
>>>>>> requested header will be included by some other headers file.
>>>>> Bruce periodically runs a script that's supposed to catch this type
>>>>> of problem.  Maybe we are overdue for another run?
>>>> Yes, but This problem is there for long time and I think Bruce's script does not
>>>> catch it.
>>> Exactly what problem do you see that he didn't catch?
>> bufpage.h includes bufmgr.h, but bufpage.h does not require any definition from
>> bufmgr.h. I think this dependency is there for long time.
>
> My scripts should have found this issue, see
> src/tools/pginclude/pgrminclude.
>

I'm going to try it and examine output.

        Zdenek

pgsql-patches by date:

Previous
From: "Tom Dunstan"
Date:
Subject: Re: [HACKERS] Database owner installable modules patch
Next
From: Kenneth Marshall
Date:
Subject: Re: updated hash functions for postgresql v1