Re: Headers dependencies cleanup - Mailing list pgsql-patches

From Zdenek Kotala
Subject Re: Headers dependencies cleanup
Date
Msg-id 47F70500.5080003@sun.com
Whole thread Raw
In response to Re: Headers dependencies cleanup  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Headers dependencies cleanup  (Bruce Momjian <bruce@momjian.us>)
List pgsql-patches
Tom Lane napsal(a):
> Zdenek Kotala <Zdenek.Kotala@Sun.COM> writes:
>>>> During my work I found some header files, which include useless headers
>>>> and on other way there are some headers which silently assume that
>>>> requested header will be included by some other headers file.
>>> Bruce periodically runs a script that's supposed to catch this type
>>> of problem.  Maybe we are overdue for another run?
>
>> Yes, but This problem is there for long time and I think Bruce's script does not
>> catch it.
>
> Exactly what problem do you see that he didn't catch?

bufpage.h includes bufmgr.h, but bufpage.h does not require any definition from
bufmgr.h. I think this dependency is there for long time.

        Zdenek

pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: Headers dependencies cleanup
Next
From: Nobuhiro Iwamatsu
Date:
Subject: [PATCH] sh: Add support Renesas SuperH