Re: Fix pg_dump dependency on postgres.h - Mailing list pgsql-patches

From Zdenek Kotala
Subject Re: Fix pg_dump dependency on postgres.h
Date
Msg-id 47EB9484.3050306@sun.com
Whole thread Raw
In response to Re: Fix pg_dump dependency on postgres.h  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches
Tom Lane napsal(a):
> Zdenek Kotala <Zdenek.Kotala@Sun.COM> writes:
>> Thank your for Your and Alvaro's comments. I attached updated patch
>> version only with YYSTYPE definition.
>
> Applied with minor revisions.  I fixed pg_conversion.h as well; the only
> remaining special inclusions in the catalog header files are of
> pg_list.h.  For the moment that header doesn't seem to be a problem
> for client-side code to include, but someday we may want to do more
> cleanup here.

Thanks.

> The immediate remaining problem is that pg_resetxlog.c still includes
> a bunch of backend-only headers, which as far as I understand still
> blocks your build requirements.  I poked at this a little bit, but
> didn't see any easy solution ...

Yes, I know about it. When I tried to solved it in November, I found some
unnecessary includes and also there are some not well placed structures and so
on. I also sent one fix which probably lost in black hole of patch queue:

See http://archives.postgresql.org/pgsql-patches/2007-10/msg00197.php

There are big work on pg_resetxlog.c and I will look on it. It probably will
require a cleanup in headers files.

        Zdenek

pgsql-patches by date:

Previous
From: "Gevik Babakhani"
Date:
Subject: Re: V1.1 patch for TODO Item: SQL-language reference parameters by name.
Next
From: Bruce Momjian
Date:
Subject: Re: Remove ipcclean