Hi Peter,
> On Oct 30, 2025, at 21:30, Peter Eisentraut <peter@eisentraut.org> wrote:
>
> I have committed most of this patch.
Thank you so much for committing my patch and for your guidance. I’m still ramping up on PostgreSQL development, and
yourguidance has been super helpful to me.
>
> I didn't like the few places in itemptr.h where you changed an existing ItemPointerData* back to ItemPointer, so I
leftthose out.
>
> More importantly, some of the proposed changes change the signatures of callback functions in the index or table AM
APIs. (And also the documentation wasn't updated.) This would break source code compatibility with existing extensions
thatuse those APIs. There are have been previous proposals like this in [0], [1] where the changes to those APIs were
notcommitted. And your other patch 'Mark function arguments of type "Datum *" as "const Datum *" where possible' might
havesimilar problems (although it looks like it's touching different places than [0] and [1]). So I left those changes
outof what I committed.
I will revisit that patch once I am back from vacation.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
