Re: Permanent settings - Mailing list pgsql-hackers

From Magnus Hagander
Subject Re: Permanent settings
Date
Msg-id 47BC92C0.4060402@hagander.net
Whole thread Raw
In response to Re: Permanent settings  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Permanent settings  ("Josh Berkus" <josh@agliodbs.com>)
List pgsql-hackers
Tom Lane wrote:
> Magnus Hagander <magnus@hagander.net> writes:
>> Tom Lane wrote:
>>> No you don't.  All you need is the output of the pg_settings view.
>>> Or at least, if that's insufficient, let's discuss exactly how.
> 
>> I can read the settings. How do I write them, if the only interface to 
>> write them is to deal with the file as a complete unit?
> 
> You write the file as a unit --- what's the problem?  We already agreed
> that the GUIs would not be trying to preserve comments in the file.

Well, I have to parse the file, and figure out where to have the 
setting. And if there are multiple configuration files, I have to parse 
multiple configuration files.

And phppgadmin has to implement the exact same parser. As will <insert 
third party app here>.

And people like JD who want such a feature *even though they may not be 
using the GUI* are left with nothing. (no, he's not the only one)

The point was exactly to move that parsing to the backend.

If we're fine with GUIs messing up the comments, then we can just have 
those functions in the backend and be fine with them messing up the 
comments.

//Magnus


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Permanent settings
Next
From: Tom Lane
Date:
Subject: Why does pg_ctl.c have its own copy of PM_VERSIONSTR?