Re: LLVM strip -x fails - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: LLVM strip -x fails
Date
Msg-id 478a73ae-ba12-a6dc-99bb-6623161354db@enterprisedb.com
Whole thread Raw
In response to Re: LLVM strip -x fails  (Peter Eisentraut <peter.eisentraut@enterprisedb.com>)
List pgsql-hackers
On 21.04.23 18:41, Peter Eisentraut wrote:
> On 20.04.23 17:33, Andres Freund wrote:
>> Peter, it's unlikely given the timeframe, but do you happen to 
>> remember why
>> you specified -x when stripping static libs? This seems to be all the 
>> way back
>> from
>>
>> commit 563673e15db995b6f531b44be7bb162330ac157a
>> Author: Peter Eisentraut<peter_e@gmx.net>
>> Date:   2002-04-10 16:45:25 +0000
>>
>>      Add make install-strip target.
>>
>>
>> Afaict the only safe thing to use when stripping static libs is
>> -g/--strip-debug.
> 
> I suspect this was copied from GNU Libtool.  Libtool still has that but 
> later changed the stripping of static libraries on darwin to "strip -S". 
>   Maybe should adopt that.

Here is the current logic in GNU Libtool:

https://github.com/autotools-mirror/libtool/blob/master/m4/libtool.m4#L2214




pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: LLVM strip -x fails
Next
From: Melanie Plageman
Date:
Subject: Re: Commitfest 2023-03 starting tomorrow!