Re: Proposal: adding --enable-shadows-warning - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: Proposal: adding --enable-shadows-warning
Date
Msg-id 4782EEA1-0A8F-45AC-AA09-387E9DD3BA71@yesql.se
Whole thread Raw
In response to Proposal: adding --enable-shadows-warning  (Chao Li <li.evan.chao@gmail.com>)
Responses Re: Proposal: adding --enable-shadows-warning
List pgsql-hackers
> On 28 Nov 2025, at 10:02, Chao Li <li.evan.chao@gmail.com> wrote:

> To make hacker’s life easier, it would make sense to always enable “-Wshadow”, however, that may have a risk of
breakingsome compilers. So thinking over, I just fell adding an opt-in “—enable-shadows-warnings” could be a solution. 

I'm not sure that adding buildsystem flags for compiler behaviour is the right
direction, isn't the environment variables like CFLAGS already covering this?

--
Daniel Gustafsson




pgsql-hackers by date:

Previous
From: Bernice Southey
Date:
Subject: Re: Second RewriteQuery complains about first RewriteQuery in edge case
Next
From: Rahila Syed
Date:
Subject: Re: Enhancing Memory Context Statistics Reporting