Re: BUG #5394: invalid __declspec for PG_MODULE_MAGIC - Mailing list pgsql-bugs

From Tom Lane
Subject Re: BUG #5394: invalid __declspec for PG_MODULE_MAGIC
Date
Msg-id 4776.1269806517@sss.pgh.pa.us
Whole thread Raw
In response to BUG #5394: invalid __declspec for PG_MODULE_MAGIC  ("Vladimir Barzionov" <snego.barsik@gmail.com>)
List pgsql-bugs
"Vladimir Barzionov" <snego.barsik@gmail.com> writes:
> In fmgr.h,
> macros PG_MODULE_MAGIC, PG_FUNCTION_INFO_V1.. are declared with incorrect
> "storage-class". It uses PGDLLIMPORT for declare __declspec().

> In general for building external DLL module, PGDLLIMPORT must be
> __declspec(dllimport). As it is.

> However in PG_MAGIC_* macro, storage class for function must be
> __declspec(dllexport).

> Same problem was already discussed for example here
> http://dbaspot.com/forums/postgresql/393683-re-general-custom-c-function-pal
> loc-broken.html

> Looks like the simplest way for correcting the issue is declaring additional
> macro (something like PGMODULEEXPORT)

If you want us to change this, you need to give a specific example of
what's going wrong for you.  Just asserting that it's wrong adds nothing
whatsoever to the previous discussions.

            regards, tom lane

pgsql-bugs by date:

Previous
From: "Vladimir Barzionov"
Date:
Subject: BUG #5394: invalid __declspec for PG_MODULE_MAGIC
Next
From: Robert Haas
Date:
Subject: Re: BUG #5392: Query Optimization