Re: pgsql: Log a warning instead of shutting down the system if we can't - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Log a warning instead of shutting down the system if we can't
Date
Msg-id 4719.1236191993@sss.pgh.pa.us
Whole thread Raw
In response to pgsql: Log a warning instead of shutting down the system if we can't  (mha@postgresql.org (Magnus Hagander))
List pgsql-committers
Magnus Hagander <magnus@hagander.net> writes:
> Tom Lane wrote:
>> This should be elog(LOG), not elog(WARNING).  Compare the treatment
>> of syntax errors within the file.

> While I can agree that they should be the same, why should they not be
> WARNING?

Because the postmaster has no client to receive a WARNING, and the log
message level is likely to be such that a WARNING won't get there
either.  Furthermore, if there are any live backends that might chance
to issue this message, having it pop up as a WARNING seems more likely
to be confusing than helpful, since it'll be unrelated to whatever SQL
command they are doing.

In general, LOG elevel should be used for background-type problems,
which is what this is.

            regards, tom lane

pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pgsql: Log a warning instead of shutting down the system if we can't
Next
From: Magnus Hagander
Date:
Subject: Re: pgsql: Log a warning instead of shutting down the system if we can't