Re: dblink un-named connection doesn't get re-used - Mailing list pgsql-hackers

From Joe Conway
Subject Re: dblink un-named connection doesn't get re-used
Date
Msg-id 47182FC1.90002@joeconway.com
Whole thread Raw
In response to dblink un-named connection doesn't get re-used  (Decibel! <decibel@decibel.org>)
Responses Re: dblink un-named connection doesn't get re-used
List pgsql-hackers
Decibel! wrote:
> Is it intentional that dblink's unnamed connections don't get re-used?

yes

> stats=# select dblink_connect('dbname=stats');
> dblink_connect
> ----------------
> OK
> (1 row)
> 
> stats=# select dblink_connect('dbname=postgres');
> dblink_connect
> ----------------
> OK
> (1 row)

> AFAIK there's no way I could possibly use or refer to the connection to 
> stats at this point; so why doesn't dblink close it when I issue the 
> second connect?

Why doesn't C free allocated memory automatically if you reassign a pointer?

No one has ever complained before, so I can't imagine that the resource 
leak is much of an issue in real world cases. But if you don't like the 
behavior, patches are gratefully accepted ;-).

Seriously though, I can change it for 8.3, but is it really worth 
back-patching?

Joe


pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: [COMMITTERS] pgsql: Consistently indent release notes for prior releases.
Next
From: Magnus Hagander
Date:
Subject: Re: max_prepared_transactions default ... why 5?