Re: Preliminary patch for tsearch example dictionaries/parsers in contrib - Mailing list pgsql-patches

From Andrew Dunstan
Subject Re: Preliminary patch for tsearch example dictionaries/parsers in contrib
Date
Msg-id 470BA144.9060002@dunslane.net
Whole thread Raw
In response to Re: Preliminary patch for tsearch example dictionaries/parsers in contrib  (karpov@sao.ru (Sergey V. Karpov))
Responses Re: Preliminary patch for tsearch example dictionaries/parsers in contrib
List pgsql-patches

Sergey V. Karpov wrote:
> Built-in regex engine seems to not support the one feature critical to
> the dict_regex operation - it is not able to report the "partial match"
> in a case when the matching fails solely due to premature end of input
> string (i.e. when matching may possibly succeed after adding some data
> to the string).
>
> If it is possible to achieve this behaviour with built-in engine, please
> point me to the right direction.
>
>

Adding new code at this stage of the process is bad enough. Adding new
code which adds a library dependency we have not previously had at this
stage of the process is quite unacceptable IMNSHO, and I will protest
very loudly about it. Quite apart from anything else it will almost
certainly break many buildfarm members.

Are we in beta or not? To me, beta means nothing but bug fixes go in,
period. No ifs, no buts, no maybes, no exceptions. And that should
definitely go for contrib as well. We need a bit of self-discipline
around here.

cheers

andrew

pgsql-patches by date:

Previous
From: Magnus Hagander
Date:
Subject: Re: [BUGS] libpq crash fix [was: Provide a way to not ask for a password in psql]
Next
From: "Heikki Linnakangas"
Date:
Subject: tsearch limitations doc correction