Re: Missing file versions for a bunch of dll/exe files in Windows builds - Mailing list pgsql-bugs

From MauMau
Subject Re: Missing file versions for a bunch of dll/exe files in Windows builds
Date
Msg-id 47099B0E358C4C14B4E4135A55AAD10C@maumau
Whole thread Raw
In response to Re: Missing file versions for a bunch of dll/exe files in Windows builds  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-bugs
From: "Michael Paquier" <michael.paquier@gmail.com>
> On Sat, Jun 21, 2014 at 11:47 AM, MauMau <maumau307@gmail.com> wrote:
>> (1)
>> lib\pgcrypto.dll doesn't have versioning info.
> Urgh, thanks I missed it. It is fixed in the patch attached by adding
> a AddDir call in the project of pgcrypto as this contrib module is
> kind of particular in the MSVC scripts. Here is the output of my
> cscript checking versioning with the new patch:

Thanks, I confirmed that pgcrypto.dll has proper versioning info.


>> (2)
>> None of the conversion_procs has versioning info.  But their Makefiles
>> have
>> PGFILEDESC line.  For example,
>> src/backend/utils/mb/conversion_procs/ascii_and_mic/Makefile has the
>> line:
>>
>> NAME  = ascii_and_mic
>> PGFILEDESC = "ascii_and_mic"
> Strange, it works for me:

Sorry, this was my mistake.  The patch application of Mkvcbuild.pm in
0002*.patch failed due to file permissions.  conversion_procs Dlls now have
correct versioning info.

I marked this CommitFest entry as ready for committer.

Regards
MauMau

pgsql-bugs by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Missing file versions for a bunch of dll/exe files in Windows builds
Next
From: matti.hameister@technologygroup.de
Date:
Subject: BUG #10728: json_to_recordset with nested json objects NULLs columns