Re: OpenSSL Applink - Mailing list pgsql-patches

From Dave Page
Subject Re: OpenSSL Applink
Date
Msg-id 4701026A.5070200@postgresql.org
Whole thread Raw
In response to Re: OpenSSL Applink  (Magnus Hagander <magnus@hagander.net>)
Responses Re: OpenSSL Applink  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches
Magnus Hagander wrote:
> Yes, that was the problem. Attached patch fixes the problem for me on
> Windows and Linux using the error mark functionality. It seems a lot
> cleaner than the other option.
 >
> Dave - can you test this one? Assuming that works, I'll go ahead and apply
> it.

Yep, looks good here. Thanks.

> I also think we have the same problem in the current code, just not for
> fopen(). We trap fopen() without anything happening inside OpenSSL, but if
> we get an error in the OpenSSL functions we call, something similar would
> likely happen.
>
> Should we backpatch all the stuff, or just the error push/pop thing?

All of it. Anyone building just libpq/psql using the old MSVC makefiles
will probably see the applink problem if they try to use client certs.

/D


pgsql-patches by date:

Previous
From: Magnus Hagander
Date:
Subject: Re: OpenSSL Applink
Next
From: Magnus Hagander
Date:
Subject: Re: 64bit compile linker problem of win32.mak.