Re: Yet more tsearch refactoring - Mailing list pgsql-patches

From Heikki Linnakangas
Subject Re: Yet more tsearch refactoring
Date
Msg-id 46E5BE50.70803@enterprisedb.com
Whole thread Raw
In response to Re: Yet more tsearch refactoring  (Teodor Sigaev <teodor@sigaev.ru>)
List pgsql-patches
Teodor Sigaev wrote:
> Heikki Linnakangas wrote:
>> * Defined new struct WordEntryPosVector that holds a uint16 length and a
>> variable size array of WordEntries. This replaces the previous
>> convention of a variable size uint16 array, with the first element
>> implying the length. WordEntryPosVector has the same layout in memory,
>> but is more readable in source code. The POSDATAPTR and POSDATALEN
>> macros are still used, though it would now be more readable to access
>> the fields in WordEntryPosVector directly.
>
> Did you check it on 64-bit boxes with strict alignment? I remember that
> was a headache for me.

No, I didn't. But I don't see how it would make a difference, the
resulting memory layout is the same AFAICS.

--
  Heikki Linnakangas
  EnterpriseDB   http://www.enterprisedb.com

pgsql-patches by date:

Previous
From: Teodor Sigaev
Date:
Subject: Re: Yet more tsearch refactoring
Next
From: Tom Lane
Date:
Subject: Re: HOT patch - version 15