Re: [HACKERS] pg_regress config - Mailing list pgsql-patches

From Magnus Hagander
Subject Re: [HACKERS] pg_regress config
Date
Msg-id 46E0401E.40306@hagander.net
Whole thread Raw
In response to Re: [HACKERS] pg_regress config  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-patches
Andrew Dunstan wrote:
>
>
> Magnus Hagander wrote:
>> Andrew Dunstan wrote:
>>
>>> I would like to add an argument to pg_regress that allows us to set some
>>> config options for the temp install. Specifically right now I am
>>> interested in setting the following:
>>>
>>>  log_line_prefix = '[%c] '
>>>  log_statement = 'all'
>>>  log_connections = 'true'
>>>
>>> But I think it makes more sense to provide for a general option setting
>>> mechanism, such as --extra_config=/path/to/some/file
>>>
>>> This would dovetail neatly with the recent suggestion that we might
>>> provide for buildfarm members to run several config sets.
>>>
>>> Thoughts?
>>>
>>
>> I think the file makes a lot more sense - would keep you from ending up
>> with really horrible commandlines. Also, it would make it easier if you
>> want to set up different configs manually (the buildfarm script can
>> always manage).
>>
>
> OK, patch attached. I called the option 'temp-config' to go with
> 'temp-install'.

I'd have used an include statement instead of copying the whole file,
but can't see anything actually wrong with it ;-)

//Magnus

pgsql-patches by date:

Previous
From: Simon Riggs
Date:
Subject: Re: HOT patch - version 15
Next
From: "Heikki Linnakangas"
Date:
Subject: Re: HOT patch - version 15