Re: [HACKERS] random_fract and aix compiler bug - Mailing list pgsql-patches

From Zeugswetter Andreas SB SD
Subject Re: [HACKERS] random_fract and aix compiler bug
Date
Msg-id 46C15C39FEB2C44BA555E356FBCD6FA4962047@m0114.s-mxs.net
Whole thread Raw
In response to [HACKERS] random_fract and aix compiler bug  ("Zeugswetter Andreas SB SD" <ZeugswetterA@spardat.at>)
Responses Re: [HACKERS] random_fract and aix compiler bug
List pgsql-patches
> !     } while (!(z > 0 && z < MAX_RANDOM_VALUE));
>
> !     } while (z == 0 || z == MAX_RANDOM_VALUE);
>
> This seems fairly ugly, since it eliminates the original coding's
> positive guarantee that the final result is in 0 < x < 1.  Does your

yes, ugly :-(

> compiler manage not to choke if we add a cast instead?
>
>     } while (!(z > 0 && z < (long) MAX_RANDOM_VALUE));
>

this does unfortunately not help, have also tried all sorts of other casts :-(

Would we be happy with the following, which would work ?

        } while (z <= 0 || z == MAX_RANDOM_VALUE);

Andreas

pgsql-patches by date:

Previous
From: Neil Conway
Date:
Subject: fix memory leak in libpq
Next
From: Neil Conway
Date:
Subject: minor psql cleanup