RE: extern + static issue in datetime.c - Mailing list pgsql-hackers

From Zeugswetter Andreas SB SD
Subject RE: extern + static issue in datetime.c
Date
Msg-id 46C15C39FEB2C44BA555E356FBCD6FA41EB388@m0114.s-mxs.net
Whole thread Raw
In response to extern + static issue in datetime.c  ("Zeugswetter Andreas SB SD" <ZeugswetterA@spardat.at>)
Responses Re: extern + static issue in datetime.c
List pgsql-hackers
I wrote:
> Current sources don't compile on AIX with xlc compiler because of the
> combined (and inconsistent ? or compiler bug) use of extern
> and static
> for the datetktbl in datetime.c.
>
> header unconditionally has:
> extern datetkn datetktbl[];
>
> source has:
> static datetkn datetktbl[] = {
>
> The usual approach would be to avoid that line in the header
> if included
>
> from datetime.c, but I think it would be better to use a const in this
> case.
>
> I think this is a general compatibility problem, and thus needs to be
> solved.

Attached is a patch that might be considered (remove static for these
globals).

Thanks
Andreas


Attachment

pgsql-hackers by date:

Previous
From: Shane Wegner
Date:
Subject: Re: Permissions for large-object comments
Next
From: Frank Joerdens
Date:
Subject: Re: Toast,bytea, Text -blob all confusing