Re: Issue on compiling pgAdmin trunk - Mailing list pgadmin-hackers

From Dave Page
Subject Re: Issue on compiling pgAdmin trunk
Date
Msg-id 46AB72BE.4000007@postgresql.org
Whole thread Raw
In response to Issue on compiling pgAdmin trunk  (Guillaume Lelarge <guillaume@lelarge.info>)
Responses Re: Issue on compiling pgAdmin trunk
List pgadmin-hackers
Guillaume Lelarge wrote:
> Hi,
>
> I had an issue when I tried to compile pgAdmin today. I did a complete
> svn update (I mean I first did rm -rf on my directory, then svn update,
> then ./configure, then make). gcc is complaining about duplicate use of
> DebuggerApiVersion :
>
> ../pgadmin/include/debugger/dbgPgConn.h:67: error: declaration of
> 'DebuggerApiVersion dbgPgConn::DebuggerApiVersion()'
> ../pgadmin/include/debugger/dbgPgConn.h:37: error: changes meaning of
> 'DebuggerApiVersion' from 'typedef enum DebuggerApiVersion
> DebuggerApiVersion'
>
> So I changed the Enum's name to DebuggerApiVersion_Enum and everything
> compiles now. Nevertheless, I'm not sure I did right, even if it
> compiles fine. So, here is my patch.
>
> Comments are more than welcome :)

Yeah, I spotted that in the auto-build last night. The fix seems sound,
but I'm not keen on the name. Perhaps just DebuggerApiVersions (note the s)?

Anyhoo, please commit if you have a minute.

Thanks, Dave.

pgadmin-hackers by date:

Previous
From: Devrim GÜNDÜZ
Date:
Subject: Small patch for tips.txt
Next
From: Dave Page
Date:
Subject: Re: Small patch for tips.txt