Re: HOT latest patch - version 8 - Mailing list pgsql-patches

From Stefan Kaltenbrunner
Subject Re: HOT latest patch - version 8
Date
Msg-id 469A54DC.7000002@kaltenbrunner.cc
Whole thread Raw
In response to Re: HOT latest patch - version 8  (Heikki Linnakangas <heikki@enterprisedb.com>)
List pgsql-patches
Heikki Linnakangas wrote:
> Stefan Kaltenbrunner wrote:
>> tried to test a bit on my Solaris 10 install(sun studio , 64bit build)
>> but I'm hitting the following while trying to initdb a new cluster:
>
> I can't reproduce this error, but I found a bug that's likely causing
> it. The patch uses InvalidOffsetNumber in lp_off to mark so called
> "redirect dead" line pointers, but that special case is not checked in
> PageGetRedirectingOffset-function, writing to a caller-supplied array
> with -1 index instead, globbering over whatever is there. Actually
> storing InvalidOffsetNumber in lp_off is a bit bogus in the first place
> since lp_off is unsigned, and InvalidOffsetNumber is -1, so I fixed that
> as well.

this seems to fix the problem for me - a least I can now successfully
initdb a new cluster with the HOT patch applied.


Stefan

pgsql-patches by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: HOT latest patch - version 8
Next
From: "Gavin M. Roy"
Date:
Subject: pg_dump --no-tablespaces patch