Re: [HACKERS] Cache query (PREPARE/EXECUTE) - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [HACKERS] Cache query (PREPARE/EXECUTE)
Date
Msg-id 4650.951324791@sss.pgh.pa.us
Whole thread Raw
In response to RE: [HACKERS] Cache query (PREPARE/EXECUTE)  ("Hiroshi Inoue" <Inoue@tpf.co.jp>)
Responses Re: [HACKERS] Cache query (PREPARE/EXECUTE)
RE: [HACKERS] Cache query (PREPARE/EXECUTE)
Re: [HACKERS] Cache query (PREPARE/EXECUTE)
List pgsql-hackers
"Hiroshi Inoue" <Inoue@tpf.co.jp> writes:
> I think so.  The problem is that Node struct couldn't be freed safely
> due to the lack of reference count in its definition.  As far as I see
> plans could be destroyed only when the memory context in which
> they are placed are destroyed.

This is overly conservative.  It should be safe to destroy a plan tree
via freeObject() if it was created via copyObject() --- and that is
certainly how the plan would get into a permanent memory context.

Currently, rule definitions are leaked in CacheContext at relcache
flushes.  I plan to start freeing them via freeObject at the beginning
of the 7.1 development cycle --- I didn't want to risk it during the
runup to 7.0, but I believe it will work fine.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: GNU make (Re: [HACKERS] Re: [PATCHES] Patch for more readable parse error messages)
Next
From: "Hiroshi Inoue"
Date:
Subject: RE: AW: [HACKERS] TRANSACTIONS