Re: ECPG failure on BF member Vaquita (Windows Vista) - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: ECPG failure on BF member Vaquita (Windows Vista)
Date
Msg-id 462FB28A.4060201@dunslane.net
Whole thread Raw
In response to Re: ECPG failure on BF member Vaquita (Windows Vista)  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: ECPG failure on BF member Vaquita (Windows Vista)  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tom Lane wrote:
>
> Hmm, and I don't have to look far to find a smoking gun:
>
> #if defined(__GNUC__) && (defined (__powerpc__) || defined(__amd64__) || defined(__x86_64__))
>     if (create_statement(lineno, compat, force_indicator, con, &stmt, query, args) == false)
> #else
>     if (create_statement(lineno, compat, force_indicator, con, &stmt, query, &args) == false)
> #endif
>
>
>   
I also see:

#if defined(__GNUC__) && (defined (__powerpc__) || defined(__amd64__) || 
defined(__x86_64__))
#define APREF ap
#else
#define APREF *ap
#endif


But I also see that my amd64/FC6 machine does pass these tests with gcc.

I would certainly be nice if we could simplify all this. And if not, we 
should have a note about why it's needed.

cheers

andrew



pgsql-hackers by date:

Previous
From: "Mark Wong"
Date:
Subject: Re: ECPG failure on BF member Vaquita (Windows Vista)
Next
From: Bruce Momjian
Date:
Subject: My upcoming travel