Re: tsearch2 regression test failures - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: tsearch2 regression test failures
Date
Msg-id 4607CC20.1020107@dunslane.net
Whole thread Raw
In response to Re: tsearch2 regression test failures  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tom Lane wrote:
> Teodor Sigaev <teodor@sigaev.ru> writes:
>   
>> !             pbuf = buf;
>> !             while( !isspace( *pbuf ) )
>> !                 pbuf++;
>> !             *pbuf = '\0';
>>     
>
> Surely the loop needs to look like
>
>     while (*pbuf && !isspace(*pbuf))
>         pbuf++;
>
>   
Yes.

But in any case, I am having difficulty in understanding why we are 
seeing a CR at all - the file should be opened in text mode, which 
should translate CR-LF in the file to a simple LF in the buffer. So 
regardless of the odd behavior of CVSNT, which presumabye caused this 
mess, it's rather strange.

Can someone please explain?

cheers

andrew




pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: tsearch2 regression test failures
Next
From: Tom Lane
Date:
Subject: Re: Server-side support of all encodings