Re: stats collector process high CPU utilization - Mailing list pgsql-performance

From Joshua D. Drake
Subject Re: stats collector process high CPU utilization
Date
Msg-id 45E8B209.1040209@commandprompt.com
Whole thread Raw
In response to Re: stats collector process high CPU utilization  (Bruce Momjian <bruce@momjian.us>)
List pgsql-performance
Bruce Momjian wrote:
> Sorry, I introduced this bug.

To the gallows with you! :) Don't feel bad, there were several hackers
that missed the math on that one.

Joshua D. Drake



>
> ---------------------------------------------------------------------------
>
> Tom Lane wrote:
>> Benjamin Minshall <minshall@intellicon.biz> writes:
>>> Tom Lane wrote:
>>>> It's sounding like what you had was just transient bloat, in which case
>>>> it might be useful to inquire whether anything out-of-the-ordinary had
>>>> been done to the database right before the excessive-CPU-usage problem
>>>> started.
>>> I don't believe that there was any unusual activity on the server, but I
>>> have set up some more detailed logging to hopefully identify a pattern
>>> if the problem resurfaces.
>> A further report led us to realize that 8.2.x in fact has a nasty bug
>> here: the stats collector is supposed to dump its stats to a file at
>> most every 500 milliseconds, but the code was actually waiting only
>> 500 microseconds :-(.  The larger the stats file, the more obvious
>> this problem gets.
>>
>> If you want to patch this before 8.2.4, try this...
>>
>> Index: pgstat.c
>> ===================================================================
>> RCS file: /cvsroot/pgsql/src/backend/postmaster/pgstat.c,v
>> retrieving revision 1.140.2.2
>> diff -c -r1.140.2.2 pgstat.c
>> *** pgstat.c    26 Jan 2007 20:07:01 -0000    1.140.2.2
>> --- pgstat.c    1 Mar 2007 20:04:50 -0000
>> ***************
>> *** 1689,1695 ****
>>       /* Preset the delay between status file writes */
>>       MemSet(&write_timeout, 0, sizeof(struct itimerval));
>>       write_timeout.it_value.tv_sec = PGSTAT_STAT_INTERVAL / 1000;
>> !     write_timeout.it_value.tv_usec = PGSTAT_STAT_INTERVAL % 1000;
>>
>>       /*
>>        * Read in an existing statistics stats file or initialize the stats to
>> --- 1689,1695 ----
>>       /* Preset the delay between status file writes */
>>       MemSet(&write_timeout, 0, sizeof(struct itimerval));
>>       write_timeout.it_value.tv_sec = PGSTAT_STAT_INTERVAL / 1000;
>> !     write_timeout.it_value.tv_usec = (PGSTAT_STAT_INTERVAL % 1000) * 1000;
>>
>>       /*
>>        * Read in an existing statistics stats file or initialize the stats to
>>
>>
>>             regards, tom lane
>>
>> ---------------------------(end of broadcast)---------------------------
>> TIP 1: if posting/reading through Usenet, please send an appropriate
>>        subscribe-nomail command to majordomo@postgresql.org so that your
>>        message can get through to the mailing list cleanly
>


--

      === The PostgreSQL Company: Command Prompt, Inc. ===
Sales/Support: +1.503.667.4564 || 24x7/Emergency: +1.800.492.2240
Providing the most comprehensive  PostgreSQL solutions since 1997
             http://www.commandprompt.com/

Donate to the PostgreSQL Project: http://www.postgresql.org/about/donate
PostgreSQL Replication: http://www.commandprompt.com/products/


pgsql-performance by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: stats collector process high CPU utilization
Next
From: "Alex Deucher"
Date:
Subject: Re: strange performance regression between 7.4 and 8.1