Re: pg_resetwal.c: duplicate '0' in hex character set for -l option validation - Mailing list pgsql-hackers

From Chao Li
Subject Re: pg_resetwal.c: duplicate '0' in hex character set for -l option validation
Date
Msg-id 45E88EAB-B8BF-48E9-BA60-061CC32A3888@gmail.com
Whole thread Raw
In response to Re: pg_resetwal.c: duplicate '0' in hex character set for -l option validation  (Michael Paquier <michael@paquier.xyz>)
Responses Re: pg_resetwal.c: duplicate '0' in hex character set for -l option validation
List pgsql-hackers

> On Mar 4, 2026, at 08:31, Michael Paquier <michael@paquier.xyz> wrote:
>
> On Mon, Mar 02, 2026 at 11:38:30AM +0800, jinbinge wrote:
>> After searching for "01234567890" and "01234567890ABCDEF" (excluding test files),
>> no other occurrences were found.
>> The attached v2 patch replaces non‑standard or redundant hexadecimal digit strings
>> in C source files with the conventional "0123456789ABCDEF".
>
> Sounds find to me.  As this is purely cosmetic, I am adding it into my
> next batch of cosmetic changes merged together.
> --
> Michael


Hi Michael,

In your recent batch commit 462fe0ff6215ae222fc866af621e4b86462289b1, I noticed that nobody was credited. Does this
meanthat people who report typo-like problems will no longer be credited? 

From my experience, submitting trivial patches is often an easy entry point for new hackers to get familiar with the
patchprocess. For that reason, I wonder if it would make sense to at least credit them as reporters? 

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/







pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Funny behavior in event trigger code with CREATE OR REPLACE VIEW and column additions
Next
From: Masahiko Sawada
Date:
Subject: Re: Is it OK to perform logging while holding a LWLock?