We're ok with the alignment issues provided the is code added to reject
O_DIRECT if the sector size is too large.
We also said we need to see some performance numbers on the effect of
the patch before it goes in.
//Magnus
Bruce Momjian wrote:
> So, do we want this patch? Are we OK on WIN32 alignment issues?
>
> ---------------------------------------------------------------------------
>
> ITAGAKI Takahiro wrote:
>> The attached is a patch to define O_DIRECT by ourselves on Windows,
>> and to map O_DIRECT to FILE_FLAG_NO_BUFFERING.
>>
>> There will be a consistency in our support between Windows and other OSes
>> that have O_DIRECT. Also, there is the following comment that says, I read,
>> we should do so.
>> | handle other flags? (eg FILE_FLAG_NO_BUFFERING/FILE_FLAG_WRITE_THROUGH)
>>
>> Is this worth doing? Do we need more performance reports for the change?
>>
>> Regards,
>> ---
>> ITAGAKI Takahiro
>> NTT Open Source Software Center
>
> [ Attachment, skipping... ]
>
>> ---------------------------(end of broadcast)---------------------------
>> TIP 2: Don't 'kill -9' the postmaster
>
