Re: Recent ecpg patch... - Mailing list pgsql-hackers

From Magnus Hagander
Subject Re: Recent ecpg patch...
Date
Msg-id 45ABEED8.8040809@hagander.net
Whole thread Raw
In response to Re: Recent ecpg patch...  (Joachim Wieland <joe@mcknight.de>)
List pgsql-hackers
Joachim Wieland wrote:
> On Thu, Jan 11, 2007 at 09:59:14PM +0100, Magnus Hagander wrote:
>> .. appears to have killed win32. It did kill my manual MSVC builds, but
>> it also seems to have killed win32 buildfarm members yak and snake:
>> http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=yak&dt=2007-01-11%2020:32:11
>> http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=snake&dt=2007-01-11%2018:30:01
> 
>> (same error on mingw and msvc)
> 
> ecpg_internal_regression_mode has to be declared at least in one file without
> the "extern" keyword.
> 
> With the attached patch I get a clean build again with MSVC.

In case nobody has confirmed that yet (I may have missed a msg or two),
with whatever got committed to cvs eventually, it builds fine on MSVC now.

//Magnus


pgsql-hackers by date:

Previous
From: markwkm@gmail.com
Date:
Subject: Re: ideas for auto-processing patches
Next
From: "Florian G. Pflug"
Date:
Subject: Re: xml type and encodings