Re: pgsql: Integrate recovery.conf into postgresql.conf - Mailing list pgsql-hackers

From Sergei Kornilov
Subject Re: pgsql: Integrate recovery.conf into postgresql.conf
Date
Msg-id 459131543267195@sas1-4b7566131ec9.qloud-c.yandex.net
Whole thread Raw
In response to Re: pgsql: Integrate recovery.conf into postgresql.conf  (Stephen Frost <sfrost@snowman.net>)
Responses Re: pgsql: Integrate recovery.conf into postgresql.conf  (Stephen Frost <sfrost@snowman.net>)
List pgsql-hackers
Hi

> I'd encourage you to look through the diff after you're finished hacking
> before sending it to the list, in case things get left in that should be
> removed, as below...
I am so sorry. I have a look before sending, but...
It's night in my timezone. I will fix tomorrow.

>>  + if (targetSettingsCount > 1)
>>  + ereport(FATAL,
>>  + (errcode(ERRCODE_INVALID_PARAMETER_VALUE),
>>  + errmsg("can not specify multiple recovery targets")));
>
> Doesn't look like you changed this based on my prior comment..?
Do you mean this one?
> I think I would have done 'if (targetSettingsCount != 1)' here.
To be sure, we need check we have one recovery target without standby mode and none or one in standby mode? Or some
anothercheck?
 

regards, Sergei


pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Re: Inadequate executor locking of indexes
Next
From: Stephen Frost
Date:
Subject: Re: pgsql: Integrate recovery.conf into postgresql.conf