Re: pgadmin3-1.6.1 - core dumped - Work around - Mailing list pgadmin-hackers

From Zdenek Kotala
Subject Re: pgadmin3-1.6.1 - core dumped - Work around
Date
Msg-id 4581B8D2.5080508@sun.com
Whole thread Raw
In response to Re: pgadmin3-1.6.1 - core dumped - Work around  (Dave Page <dpage@postgresql.org>)
Responses Re: pgadmin3-1.6.1 - core dumped - Work around  (Dave Page <dpage@postgresql.org>)
List pgadmin-hackers
Dave Page wrote:
> Dhanaraj M wrote:
>> Sorry for the wrong work around.
>> But it crahes in this step...
>>     if (s->GetConnected() && s->GetConnection()->GetHost() ==
>> conn->GetHost() && s->GetConnection()->GetPort() == conn->GetPort())^M
>>                      I think 'conn' is destroyed already... or some
>> other problem.
>>
>> Any idea??
>
> Sorry - just building wx now....
>
> Try testing conn at the beginning of the if statement:
>
> if (conn && s->GetConnected() && s->GetConnection()->GetHost() ==
>
> I'm still not sure how you're getting into that code when you close the
> form though...

The root cause is destructor of frmQuery dialog. It removes all
connection from combo box exclude last item - "new connection". Each
deletion invoke frmQuery::OnChangeConnection event and the
OnChangeConnection method invokes "new connection dialog" in the last
step. And because there are some empty combo boxes on this dialog, gtk
generates core.

My suggestion is disable event generation for cbConnection in the
destructor.

    Zdenek

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: Re: pgadmin3-1.6.1 - core dumped - Work around
Next
From: Dave Page
Date:
Subject: Re: pgadmin3-1.6.1 - core dumped - Work around