Re: eliminate xl_heap_visible to reduce WAL (and eventually set VM on-access) - Mailing list pgsql-hackers

> On Nov 21, 2025, at 09:09, Chao Li <li.evan.chao@gmail.com> wrote:
>
> I’d stop here today, and continue reviewing rest commits in next week.

I continue reviewing today.

0004 This a pure refactoring. It splits heap_page_prune_and_freeze to multiple small functions. LGTM, no comment.

0005 overall good, a few nit comments as below.

0006, 0007 look good, no comment.

5 - 0005 - heapam.h
```
+    /*
+     *
+     * vmbuffer is the buffer that must already contain contain the required
+     * block of the visibility map if we are to update it. blk_known_av is the
```

Nit:

* an unnecessary empty comment line.
* “contain contain” => “contain"

6 - 0005 heapam_xlog.c
```
+         * The critical integrity requirement here is that we must never end
+         * up with with the visibility map bit set and the page-level
```

Nit: “with with” => “with”

I will continue reviewing 0008 and rest tomorrow.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/