Re: Remove MSVC scripts from the tree - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Remove MSVC scripts from the tree
Date
Msg-id 454653fd-d2ab-45f1-9568-9342c1ed9d77@eisentraut.org
Whole thread Raw
In response to Re: Remove MSVC scripts from the tree  (Peter Eisentraut <peter@eisentraut.org>)
Responses Re: Remove MSVC scripts from the tree
Re: Remove MSVC scripts from the tree
Re: Remove MSVC scripts from the tree
Re: Remove MSVC scripts from the tree
List pgsql-hackers
On 18.12.23 14:52, Peter Eisentraut wrote:
>> 2) I had seen that if sed/gzip is not available meson build will fail:
>> 2.a)
>> Program gsed sed found: NO
>> meson.build:334:6: ERROR: Program 'gsed sed' not found or not executable
> 
> Yes, this would need to be improved.  Currently, sed is only required if 
> either selinux or dtrace is enabled, which isn't supported on Windows. 
> But we should adjust the build scripts to not fail the top-level setup 
> run unless those options are enabled.
> 
>> 2.b)
>> Program gzip found: NO
>> meson.build:337:7: ERROR: Program 'gzip' not found or not executable
> 
> gzip is only required for certain test suites, so again we should adjust 
> the build scripts to not fail the build but instead skip the tests as 
> appropriate.

Here are patches for these two issues.  More testing would be appreciated.
Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Allow custom parameters with more than one dot in config files.
Next
From: "Tristan Partin"
Date:
Subject: Re: Add --check option to pgindent