Re: guc comment changes (was Re: Getting a move on for 8.2 - Mailing list pgsql-hackers

From Zdenek Kotala
Subject Re: guc comment changes (was Re: Getting a move on for 8.2
Date
Msg-id 45113A77.5040100@sun.com
Whole thread Raw
In response to guc comment changes (was Re: Getting a move on for 8.2 beta)  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tom Lane wrote:
> Peter Eisentraut <peter_e@gmx.net> writes:
>> That does not mean that the patch is bad, and I certainly support the 
>> feature change.  But I can't efficiently review the patch.  If someone 
>> else wants to do it, go ahead.
> 
> I've finally taken a close look at this patch, and I don't like it any
> more than Peter does.  The refactoring might or might not be good at its
> core, but as presented it is horrid.  As just one example, it replaces one
> reasonably well-commented function with three misnamed, poorly commented
> functions.  In place of

Thanks Tom for your time to look on the code and for your feedback. It 
is very useful for me.
Thanks Zdenek


pgsql-hackers by date:

Previous
From: Tom Dunstan
Date:
Subject: Re: Opinion wanted on UUID/GUID datatype output formats.
Next
From: Gevik Babakhani
Date:
Subject: Re: Opinion wanted on UUID/GUID datatype output formats.