"Shigehiro honda" <fwif0083@mb.infoweb.ne.jp> writes:
> it seems that the -z option of pg_basebackup does not work correctly.
> In getopt_long() function, there is not 'z' in 3rd argument.
Ooops. Doesn't look like this got tested much (or at all).
> And Z_DEFAULT_COMPRESSION are defined as (-1) in my zlib.h and it does only
> test (compresslevel > 0) in the code, so the command does not compress
> anyway.
I think it would be sufficient to test (compresslevel != 0) in all these
places, instead of hard-wiring knowledge of Z_DEFAULT_COMPRESSION.
Will fix, thanks for the report!
> $ diff pg_basebackup.c.DIST pg_basebackup.c
BTW, plain diffs are just about useless, since patch can't apply them
safely if the code has changed at all. Please send -c or -u format
diffs in future.
regards, tom lane
