Re: [PATCHES] Generic Monitoring Framework with DTrace patch - Mailing list pgsql-hackers

From Robert Lor
Subject Re: [PATCHES] Generic Monitoring Framework with DTrace patch
Date
Msg-id 44C28E28.2050206@sun.com
Whole thread Raw
In response to Re: [PATCHES] Generic Monitoring Framework with DTrace patch  (Peter Eisentraut <peter_e@gmx.net>)
Responses Re: [PATCHES] Generic Monitoring Framework with DTrace patch  (Peter Eisentraut <peter_e@gmx.net>)
List pgsql-hackers
Peter Eisentraut wrote:

>Robert Lor wrote:
>  
>
>>Now I'm getting a different type of error. After running the patch
>>command, the configure file is partially patched but not the others.
>>Attached is configure.rej. I just checked out the source from CVS.
>>    
>>
>
>Sorry, there must be something wrong with your source code or patch 
>tools, or the patch is mangled by email.  I'm not sure.
>
>  
>
I was able to apply the patch after splitting it into individual  files, 
ran dos2unix on each, and removed the diff line. I believe the problem 
is with the patch tool.

Anyways, I tested the patch with --enable-dtrace and/or DTRACEFLAGS, and 
it works like a charm! If DTRACEFLAGS is not use, dtrace will default to 
32 bit which is what we want. When building a 64 bit binary with 
--enable-dtrace, DTRACEFLAGS needs to be set to '-64'. I will submit a 
doc patch to explain all of the above.

There is one minor issue - "gmake clean" doesn't remove probe.o.

Regarding where to put probe.d, will src/probe.d work since probes for 
all subsystems will go into this one file.

Thanks a bunch Peter!

Regards,
-Robert




pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: [PATCHES] Generic Monitoring Framework with DTrace patch
Next
From: Christopher Browne
Date:
Subject: Re: Documenting Replication Solutions