Re: src/tools/pginclude considered harmful (was Re: [PATCHES] - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: src/tools/pginclude considered harmful (was Re: [PATCHES]
Date
Msg-id 44B7F090.60906@dunslane.net
Whole thread Raw
In response to src/tools/pginclude considered harmful (was Re: [PATCHES] toast index entries again)  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: src/tools/pginclude considered harmful (was Re: [PATCHES]  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tom Lane wrote:

>In combination with the amount of time wasted over the past two days,
>it is now perfectly clear that the existing pginclude tools are not
>NEARLY good enough to detect what they are breaking.  I would like to
>propose that we revert all the include-related changes of the past two
>days, and that src/tools/pginclude be removed from the CVS tree, until
>such time as it is rewritten to be much smarter about what it is doing.
>
>  
>

I agree with reverting. The tool looks pretty broken anyway, with 
hardcoded paths and all sorts of stuff quite apart from logic problems.

cheers

andrew


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [PATCHES] putting CHECK_FOR_INTERRUPTS in qsort_comparetup()
Next
From: Peter Eisentraut
Date:
Subject: Re: [PATCHES] putting CHECK_FOR_INTERRUPTS in qsort_comparetup()