Re: Fix gistkillitems & add regression test to microvacuum - Mailing list pgsql-hackers

From Andrey Borodin
Subject Re: Fix gistkillitems & add regression test to microvacuum
Date
Msg-id 449DFC8A-CF54-493E-9366-AF9C73C782AA@yandex-team.ru
Whole thread Raw
In response to Re: Fix gistkillitems & add regression test to microvacuum  (Kirill Reshke <reshkekirill@gmail.com>)
Responses Re: Fix gistkillitems & add regression test to microvacuum
List pgsql-hackers

> On 15 Jan 2026, at 22:59, Kirill Reshke <reshkekirill@gmail.com> wrote:
>
> PFA v2 which leaves the test in-place.
>
> Also commit message improvements.

Yeah, killtuples for GiST root page is broken. Your patch is fixing it.
I don't think we should backpatch this, the bug is harmless, but for master the patch LGTM.
It would be good to assign so->curBlkno and so->curBlkno together. But gistScanPage() is the only place with access to
theblock number. 

+# Test gist, but with fewer rows - that killitems used to be buggy.

Probably, in this comment we can explicitly say that killitems was buggy, but now is fixed.

Thanks!


Best regards, Andrey Borodin.


pgsql-hackers by date:

Previous
From: Tatsuo Ishii
Date:
Subject: Re: Row pattern recognition
Next
From: shveta malik
Date:
Subject: Re: Proposal: Conflict log history table for Logical Replication