Re: plpython crash - Mailing list pgsql-hackers

From Tom Lane
Subject Re: plpython crash
Date
Msg-id 4474.1313615431@sss.pgh.pa.us
Whole thread Raw
In response to Re: plpython crash  (Jan Urbański <wulczer@wulczer.org>)
Responses Re: plpython crash
List pgsql-hackers
Jan Urbański <wulczer@wulczer.org> writes:
> Here are two patches that fix two separate bugs that you found
> simultaneously. Because they're actually separate issues, it turned out
> fixing them was a bit more tricky than I expected (fixing one was
> unmasking the other one etc).

Applied with one non-cosmetic change: I got rid of the test on
TransactionIdIsValid(arg->typrel_xmin) in PLy_input_tuple_funcs,
as well as where you'd copied that logic in PLy_output_tuple_funcs.
AFAICS skipping the update on the xmin/tid, if we're coming through
there a second time, would be simply wrong.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Greg Smith
Date:
Subject: Displaying accumulated autovacuum cost
Next
From: Tom Lane
Date:
Subject: Re: FATAL: ReleaseSavepoint: unexpected state STARTED